-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL skip GPU unpacking of the rest of the block if a bad block is detected - 130x #42395
ECAL skip GPU unpacking of the rest of the block if a bad block is detected - 130x #42395
Conversation
A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_13_0_X. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type ecal |
enable gpu |
backport of #42301 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ade098/33943/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
I let @rappoccio and @perrotta comment, but normally one would make the 13_1_X backport as well. |
I agree. If we backport in an older release cycle it is a good habit to also backport in all open cycles in between, unless there are counterindications in doing so. |
OK I will make the 13_1_X backport as well then. |
13_1_X backport: #42406 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Skip the GPU unpacking of the rest of the block if a bad block is detected in one thread. This behaviour matches the one of the CPU unpacker.
Backport of #42301 for HLT.
PR validation:
No crashes with integrity errors observed in runs 367771, 368547, and 368724 in #39568. Passes WF 12434.512